fix(news): custom RSS feed save fails with validation error when no logo by ChuckBuilds · Pull Request #329 · ChuckBuilds/LEDMatrix

ChuckBuilds · 2026-05-13T19:13:11Z

Root Cause

_set_missing_booleans_to_false was unconditionally creating an empty dict for every nested-object sub-property when processing array items. For the news plugin's custom_feeds, this produced logo: {} on every feed item where no logo was uploaded.

jsonschema then validated that empty object against the logo schema's required: ["id", "path"] constraint and rejected it — even though logo itself is optional on the item.

Execution order that exposed the bug:

fix_array_structures — converts {"0": {...}} → [{...}]
_set_missing_booleans_to_false — injected logo: {} on items with no logo
_filter_config_by_schema — passed arrays through unchanged (didn't strip the empty object)
validate_config_against_schema — failed on logo: {} missing id and path

Changes

_set_missing_booleans_to_false (api_v3.py ~line 4279): Skip recursion into a nested object sub-property when it isn't already present in the array item. The function's purpose is to set unchecked boolean checkboxes to False — there's no reason to create an optional object like logo just to search for booleans inside it.

_filter_config_by_schema (api_v3.py ~line 4426): Extended to recurse into array items when the items schema has properties. Previously arrays passed through unchanged, so any extra field on a feed item (legacy data, migration artifacts) would survive to validation where additionalProperties: false would reject it. This is a defensive improvement that catches any future similar case.

Test Plan

Add a custom RSS feed with name + URL but no logo → save → should succeed (was failing)
Add a custom RSS feed with a logo uploaded → save → should still succeed
Edit an existing feed with a logo → save without changing the logo → should still succeed
Confirm config/config.json has no spurious logo: {} entries on feeds without logos

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved form validation for configurations with nested objects and arrays to ensure stricter adherence to defined schemas, preventing invalid data submission.
- Fixed handling of boolean checkbox values in nested forms during partial submissions to avoid creating unintended empty objects.
- Enhanced schema-based configuration filtering to consistently remove extra fields that would fail validation against defined constraints.

_set_missing_booleans_to_false was unconditionally creating an empty dict for every nested-object sub-property when processing array items. For the news plugin's custom_feeds, this produced logo:{} on every feed item that had no logo uploaded. jsonschema then validated that empty object against logo's required:["id","path"] constraint and failed. Fix: skip recursion into a sub-object when it isn't already present in the array item. There's no reason to create an optional object like logo just to look for boolean fields inside it. Also extend _filter_config_by_schema to recurse into array items when the items schema has properties. Previously arrays were passed through unchanged, so any stray field on a feed item (legacy data, migration artifacts) would survive to validation where additionalProperties:false would reject it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

coderabbitai · 2026-05-13T19:13:33Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0ed89cff-0ba2-47fe-9df3-439395259833

📥 Commits

Reviewing files that changed from the base of the PR and between 3b45a75 and fddd316.

📒 Files selected for processing (1)

web_interface/blueprints/api_v3.py

📝 Walkthrough

Walkthrough

This PR refines two internal configuration helpers in api_v3.py. Boolean backfilling now conservatively checks existence before recursing into nested objects, preventing spurious empty object creation during partial form submissions. Schema-based filtering was expanded to recursively process arrays of objects, ensuring extra fields are consistently stripped regardless of nesting depth.

Changes

Configuration Form and Schema Handling

Layer / File(s)	Summary
Boolean field backfilling for nested objects `web_interface/blueprints/api_v3.py`	`_set_missing_booleans_to_false` now checks that sub-object keys exist and are dicts before descending into them, avoiding creation of new optional sub-objects during boolean backfilling for partial checkbox submissions within array items.
Schema-based filtering for nested arrays and objects `web_interface/blueprints/api_v3.py`	`_filter_config_by_schema` now recursively filters array properties containing objects with properties; each array element is filtered using schema matching with correct prefix handling to strip extra fields consistently.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The pull request title refers to fixing RSS feed validation, but the changeset modifies internal helper functions in api_v3.py for form processing and schema filtering, which is not specifically about RSS feeds.	Update the title to reflect the actual changes, such as: 'fix(api): prevent creation of empty objects in nested form properties during array processing' or similar, or if the RSS context is important, ensure changes align with that scope.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/news-custom-rss-feed-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codacy-production · 2026-05-13T19:14:29Z

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

ChuckBuilds merged commit 452afac into main May 13, 2026
2 checks passed

ChuckBuilds deleted the fix/news-custom-rss-feed-validation branch May 13, 2026 19:51

coderabbitai Bot mentioned this pull request Jun 29, 2026

fix(web): repair news ticker custom-feeds save for JSON path #376

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(news): custom RSS feed save fails with validation error when no logo#329

fix(news): custom RSS feed save fails with validation error when no logo#329
ChuckBuilds merged 1 commit into
mainfrom
fix/news-custom-rss-feed-validation

ChuckBuilds commented May 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 13, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

codacy-production Bot commented May 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ChuckBuilds commented May 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Root Cause

Changes

Test Plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

codacy-production Bot commented May 13, 2026

Up to standards ✅

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ChuckBuilds commented May 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 13, 2026 •

edited

Loading